slurm script inference#1675
Merged
Merged
Conversation
grassesi
requested changes
Jan 26, 2026
Comment on lines
-193
to
+202
| # Entry point for slurm script. | ||
| # Check whether --from_run_id passed as argument. | ||
| if any("--from_run_id" in arg for arg in sys.argv): | ||
| train_continue() | ||
|
|
||
| if any("train" in arg for arg in sys.argv): | ||
| # Entry point for slurm script. | ||
| # Check whether --from_run_id passed as argument. | ||
| if any("--from_run_id" in arg for arg in sys.argv): | ||
| train_continue() | ||
| else: | ||
| train() | ||
| elif any("inference" in arg for arg in sys.argv): | ||
| inference() |
Contributor
There was a problem hiding this comment.
Just adding a "train" or "inference" as an argument breaks the cli parser since it does not know about these arguments yet. Please pull the changes from mtar#1, or implement the stage argument properly in cli.py
grassesi
marked this pull request as ready for review
January 26, 2026 01:55
get stage info from environment variable.
grassesi
approved these changes
Jan 26, 2026
iluise
pushed a commit
that referenced
this pull request
Jan 27, 2026
* add argument * check stage argument * removed unnecessary code * arbitrary position arguments * Fix error text * get stage info from environment variable. * Update run_train.py --------- Co-authored-by: Simon Grasse <s.grasse@fz-juelich.de>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Decide on the training stage based on the first argument. Added part to !99
Issue Number
Closes #1308
Is this PR a draft? Mark it as draft.
Checklist before asking for review
./scripts/actions.sh lint./scripts/actions.sh unit-test./scripts/actions.sh integration-testlaunch-slurm.py --time 60